Skip to content

Conversation

@Hweinstock
Copy link
Contributor

Problem

Performance test was reliant on dead code removed in #6218

Solution

  • update thresholds to accommodate the change.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock changed the title test(perf): update thresholds in buildIndex tests to accommodate changes. test(perf): update thresholds in buildIndex tests Dec 12, 2024
@Hweinstock
Copy link
Contributor Author

/runIntegrationTests

@Hweinstock Hweinstock marked this pull request as ready for review December 12, 2024 22:57
@Hweinstock Hweinstock requested a review from a team as a code owner December 12, 2024 22:57
@Hweinstock Hweinstock merged commit 5b5df85 into aws:master Dec 12, 2024
32 of 39 checks passed
@Hweinstock Hweinstock deleted the perf/updateThresholds branch December 12, 2024 23:08
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
## Problem
Performance test was reliant on dead code removed in
aws#6218

## Solution
- update thresholds to accommodate the change. 

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).

License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants